Avoid unnecessary dependencies on @glimmer
types
#1304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The published types from this package rely on
@glimmer/interfaces
in two places:render()
to represent that it can accept a componentgetComponentManager
helperThis PR updates the signature of
render()
to simply accept anyobject
as its first parameter. This is actually more accurate than the current type—at runtime,render()
only requires that the object it receives is either a template or is some object with a component manager, but "has a component manager" isn't something we're able to model in the TS type system.It also updates the return type of the
getComponentManager
utility tounknown
, as we never actually interact with the manager, we only check for its existence. (In reality this change is likely unnecessary since this.d.ts
file won't end up in the import path for consumers using public APIs, but updating this removes references to@glimmer/interfaces
in the built types directory entirely.)