ensureSafeComponent is not needed on Ember > 3.25 #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This usage of `ensureSafeComponent` is a no-op on all the versions of ember supported by this addon.
chancancode
added a commit
to chancancode/discourse
that referenced
this pull request
Dec 14, 2023
Mainly we are after emberjs/ember-test-helpers#1445 so the Ember 5 test suite doesn't fail on canary, but also took some code from emberjs/ember-test-helpers#1378 as needed to make the code make sense.
davidtaylorhq
pushed a commit
to discourse/discourse
that referenced
this pull request
Jan 3, 2024
Mainly we are after emberjs/ember-test-helpers#1445 so the Ember 5 test suite doesn't fail on canary, but also took some code from emberjs/ember-test-helpers#1378 as needed to make the code make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This usage of
ensureSafeComponentis a no-op on all the versions of ember supported by this addon.