Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer Ember.assign over Ember.merge #150

Merged
merged 1 commit into from May 5, 2016
Merged

Prefer Ember.assign over Ember.merge #150

merged 1 commit into from May 5, 2016

Conversation

ghost
Copy link

@ghost ghost commented Apr 12, 2016

@bendemboski
Copy link
Contributor

Yes please!

@AmilKey
Copy link

AmilKey commented Apr 15, 2016

@rwjblue merge plz

@simonihmig
Copy link
Contributor

👍

1 similar comment
@danjamin
Copy link
Contributor

👍

@trianglegrrl
Copy link

trianglegrrl commented Apr 26, 2016

Whassup with the loader.js test failure? I just created almost exactly the same pull request (maybe exactly the same) and am having the same issue with loader.js.

ENOENT, no such file or directory '/Users/alaina/projects/ember-test-helpers/tmp/funnel-input_base_path-SDCh6fD3.tmp/0/loader.js'
Error: ENOENT, no such file or directory '/Users/alaina/projects/ember-test-helpers/tmp/funnel-input_base_path-SDCh6fD3.tmp/0/loader.js'
    at Error (native)
    at Object.fs.lstatSync (fs.js:792:18)
    at symlink (/Users/alaina/projects/ember-test-helpers/node_modules/broccoli-funnel/node_modules/symlink-or-copy/index.js:60:26)
    at Function.symlinkOrCopySync (/Users/alaina/projects/ember-test-helpers/node_modules/broccoli-funnel/node_modules/symlink-or-copy/index.js:55:5)
    at Funnel._copy (/Users/alaina/projects/ember-test-helpers/node_modules/broccoli-funnel/index.js:394:19)
    at Funnel.processFile (/Users/alaina/projects/ember-test-helpers/node_modules/broccoli-funnel/index.js:377:8)
    at Funnel.applyPatch [as _applyPatch] (/Users/alaina/projects/ember-test-helpers/node_modules/broccoli-funnel/index.js:294:12)
    at Funnel.<anonymous> (/Users/alaina/projects/ember-test-helpers/node_modules/broccoli-funnel/index.js:246:10)
    at Array.forEach (native)
    at Funnel.processFilters (/Users/alaina/projects/ember-test-helpers/node_modules/broccoli-funnel/index.js:245:9)
npm ERR! Test failed.  See above for more details.

@rwjblue
Copy link
Member

rwjblue commented Apr 26, 2016

loader moved its location, and our local build tooling is using the wrong path

@rwjblue rwjblue merged commit ce7fdbe into emberjs:master May 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants