Deprecation Warning thrown with needs:[]
#196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 13, 2017 21:17
…ds is provided. add an appropriate test case
Turbo87
reviewed
Feb 14, 2017
| setupRegistry(); | ||
| testModule = new TestModuleForComponent('pretty-color', { needs: ['x:foo'] }); | ||
| notOk(deprecations.find(function(deprecation) { | ||
| return deprecation.length === 3 && deprecation[2].id === deprecationId; |
There was a problem hiding this comment.
would it make sense to only collect the id properties in the mocked deprecate() function above to simplify the logic here?
There was a problem hiding this comment.
You are probably right. It would simplify the overall logic
Turbo87
approved these changes
Feb 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moduleForComponentunit test deprecation being raised even ifneedsis provided.Fixes: #195