Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to ensure ember-data from npm works properly. #200

Merged
merged 2 commits into from
Apr 3, 2017
Merged

Updates to ensure ember-data from npm works properly. #200

merged 2 commits into from
Apr 3, 2017

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Apr 2, 2017

No description provided.

@Turbo87
Copy link
Member

Turbo87 commented Apr 2, 2017

I don't get it... why is this necessary?

@rwjblue
Copy link
Member Author

rwjblue commented Apr 2, 2017

Ember-data (somewhere around 2.11) added some custom babel plugins, due to ordering issues they are setting this.options.babel in the included hook. Without these changes to call included the proper babel plugins are not setup and therefore the resulting build is not runnable (e.g. it does not strip usage of the heimdall global, so errors are thrown during eval).

@rwjblue rwjblue merged commit 9b5b4b6 into emberjs:master Apr 3, 2017
@rwjblue rwjblue deleted the update-for-latest-ember-data branch April 3, 2017 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwjblue @Turbo87