Ensure RSVP promises do not need manual Ember.run wrapping. #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
auto-run-wrap-promises
branch
from
1417770
to
8eabdaf
Compare
This is essentially doing the same thing that was added way back in Ember 1.6/1.7 by Stef. The basic gist is that whenever something is triggering RSVP's `async` it will wrap that in a `Ember.run`. This prevents folks from getting the autorun error for just resolving promises...
rwjblue
force-pushed
the
auto-run-wrap-promises
branch
from
8eabdaf
to
1539b17
Compare
|
LGTM. Do u want me to test it locally on ember-native-dom-helpers? |
trentmwillis
approved these changes
Apr 4, 2017
|
FWIW, this mirrors what is done in ember's ember-testing package for acceptance tests now. The super long term goal is to slowly decouple from ember-testing... |
|
@cibernox - I do not think this will result in any changes to ember-native-dom-helpers actually... |
|
@rwjblue I understood that this was making |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially doing the same thing that was added way back in Ember 1.6/1.7 by Stef.
The basic gist is that whenever something is triggering RSVP's
asyncit will wrap that in aEmber.run. This prevents folks from getting the autorun error for just resolving promises...This brings the ember-metal-test-friendly-promises feature (from emberjs/ember.js#4176) to ember-test-helpers.