Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move integration container logic to TestModule #24

Merged
merged 2 commits into from
Mar 12, 2015

Conversation

nikz
Copy link
Contributor

@nikz nikz commented Mar 12, 2015

This moves the integration logic up into TestModule, so that you can specify:

  integration: true

And you'll be able to resolve other units in your application without adding them to needs.

(thanks @rwjblue!)

@rwjblue
Copy link
Member

rwjblue commented Mar 12, 2015

LGTM

@rwjblue
Copy link
Member

rwjblue commented Mar 12, 2015

@ef4 / @dgeb - Can you 👍 / 👎 ? This looks great, and should satisfy my comments in #21.

@ef4
Copy link
Contributor

ef4 commented Mar 12, 2015

👍

dgeb added a commit that referenced this pull request Mar 12, 2015
Move integration container logic to TestModule
@dgeb dgeb merged commit cdce5e8 into emberjs:master Mar 12, 2015
@dgeb
Copy link
Member

dgeb commented Mar 12, 2015

Nice work - thanks @nikz 👍

@cibernox
Copy link
Contributor

Is this the end of needs: ['every', 'single', 'model', 'in', 'my', 'app', 'in', 'unit', 'tests'] ??

@rwjblue
Copy link
Member

rwjblue commented Mar 12, 2015

@cibernox - Yes, and it is released in ember-qunit@0.2.11.

@cibernox
Copy link
Contributor

@rwjblue Updated ember-qunit in bower.json but I still need to specify needs on my model tests.

@ef4
Copy link
Contributor

ef4 commented Mar 12, 2015

@cibernox You need to opt in to the new behavior by passing integration:true to your moduleFor call(s).

@cibernox
Copy link
Contributor

It woks now: moduleForModel('post', { integration: true });

@IanVS
Copy link

IanVS commented Apr 6, 2015

Is this going to be added to the guides and documentation? (unless it's there already and I just can't find it)

I'm pretty new to Ember, and I'm glad I stumbled across this PR. It's going to be so nice not to have to include all the needs in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants