Expose isSettled utility function.
#248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple refactoring of the existing `settled` helper that
exposes an `isSettled()` function which can be used generally to confirm
that there are is no pending async.
One example use case is for `ember-qunit` (and also `ember-mocha`) to
implement something like:
```js
import { isSettled } from '@ember/test-helpers';
QUnit.testDone(function(results) {
if (!isSettled) {
throw new Error(`${results.name} leaks async`);
}
});
```
Turbo87
approved these changes
Nov 30, 2017
|
😩 ember-beta is failing now due to emberjs/ember.js#15831 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple refactoring of the existing
settledhelper that exposes anisSettled()function which can be used generally to confirm that there are is no pending async.One example use case is for
ember-qunit(and alsoember-mocha) to implement something like: