Use build stages to fail early... #255
Conversation
|
fancy, I definitely support this 👍 |
package.json
Outdated
| @@ -25,7 +25,9 @@ | |||
| "scripts": { | |||
| "build": "ember build", | |||
| "start": "ember server", | |||
| "test": "ember try:each" | |||
| "test": "ember try:each", | |||
| "test:default": "ember test", | |||
There was a problem hiding this comment.
I prefer test: ember test and test:all: ember try:each 🤔
There was a problem hiding this comment.
ya, same, I'll update to that
rwjblue
force-pushed
the
attempt-multi-stage-build
branch
2 times, most recently
from
3c12b38
to
a2c3db9
Compare
|
@Turbo87 - OK, I'm done playing around with this. Ready for review again... |
| @@ -36,22 +61,7 @@ before_install: | |||
| - export PATH=$HOME/.yarn/bin:$PATH | |||
|
|
|||
| install: | |||
| - yarn install --no-lockfile | |||
There was a problem hiding this comment.
I removed this because ember try:one (when useYarn: true is specified in config) already does yarn install --no-lockfile --ignore-engines when it is installing the scenario.
There was a problem hiding this comment.
if it is runnin yarn install --no-lockfile and node_modules already exists, are you sure it updates all deps to the latest possible versions?
There was a problem hiding this comment.
No, I'm unsure. I'll add an explicit job to the first stage that is explicity testing transitive deps with the default set ("current" ember-source).
There was a problem hiding this comment.
OK, updated to add a single --no-lockfile job to the first stage. This way we don't have to ignore the lockfile for all jobs, and hopefully with this setup we can easily identify failures due to transient deps vs failures due to actual repo changes.
rwjblue
changed the title
package.json
Outdated
| "test": "ember try:each" | ||
| "test": "ember test", | ||
| "test:all": "ember try:each", | ||
| "lint": "eslint addon-test-support config tests" |
There was a problem hiding this comment.
Great point, I'll copy from my other PR in ember-cli.
| @@ -36,22 +61,7 @@ before_install: | |||
| - export PATH=$HOME/.yarn/bin:$PATH | |||
|
|
|||
| install: | |||
| - yarn install --no-lockfile | |||
There was a problem hiding this comment.
if it is runnin yarn install --no-lockfile and node_modules already exists, are you sure it updates all deps to the latest possible versions?
rwjblue
force-pushed
the
attempt-multi-stage-build
branch
from
a2c3db9
to
1753294
Compare
rwjblue
force-pushed
the
attempt-multi-stage-build
branch
from
1753294
to
9151d01
Compare
No description provided.