-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring over DOM helper implementation. #258
Commits on Dec 15, 2017
-
Configuration menu - View commit details
-
Copy full SHA for f5396fa - Browse repository at this point
Copy the full SHA f5396faView commit details -
Add initial implementations for
click
andfocus
.Original implementations are from https://github.com/cibernox/ember-native-dom-helpers and then modified: * Prefer default exports when reasonable * Remove manual run-wrapping when firing events (event listeners should already be run-wrapped). * Allow `focusin` to bubble in `focus` * Remove `context` arguments from helper methods.
Configuration menu - View commit details
-
Copy full SHA for 657e8d8 - Browse repository at this point
Copy the full SHA 657e8d8View commit details -
Bring over
blur
implementation.Original implementations are from https://github.com/cibernox/ember-native-dom-helpers and then modified: * Added `fireEvent(element, 'focusout')` * Remove run wrapping
Configuration menu - View commit details
-
Copy full SHA for 31e66a8 - Browse repository at this point
Copy the full SHA 31e66a8View commit details -
Add triggerEvent and triggerKeyEvent.
Original implementations are from https://github.com/cibernox/ember-native-dom-helpers and then modified: * Remove run wrapping
Configuration menu - View commit details
-
Copy full SHA for 4b91a8c - Browse repository at this point
Copy the full SHA 4b91a8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 534e330 - Browse repository at this point
Copy the full SHA 534e330View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56c6026 - Browse repository at this point
Copy the full SHA 56c6026View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1220ed4 - Browse repository at this point
Copy the full SHA 1220ed4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59596f8 - Browse repository at this point
Copy the full SHA 59596f8View commit details -
Ensure
focus
throws if invoked with unfocusable selector.Extract `_focus` helper method that can be used from `click` to avoid the assertion...
Configuration menu - View commit details
-
Copy full SHA for e5f84cd - Browse repository at this point
Copy the full SHA e5f84cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 51a5da8 - Browse repository at this point
Copy the full SHA 51a5da8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 457333e - Browse repository at this point
Copy the full SHA 457333eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e0cc6c - Browse repository at this point
Copy the full SHA 2e0cc6cView commit details -
Even though https://w3c.github.io/uievents/#events-focusevent-event-order suggests that `focus` is always fired after `focusin`, after testing on Firefox, Chrome, and Safari (snippet below) this is not true. ```js let element = document.createElement('input'); ['mousedown', 'mouseup', 'click', 'focus', 'focusin'].forEach(type => { element.addEventListener(type, () => { console.log('event:', type); }); }); document.body.appendChild(element); ```
Configuration menu - View commit details
-
Copy full SHA for 622ce97 - Browse repository at this point
Copy the full SHA 622ce97View commit details -
Configuration menu - View commit details
-
Copy full SHA for da7d8e5 - Browse repository at this point
Copy the full SHA da7d8e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa9f7c1 - Browse repository at this point
Copy the full SHA fa9f7c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05d1f00 - Browse repository at this point
Copy the full SHA 05d1f00View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbbb7a3 - Browse repository at this point
Copy the full SHA dbbb7a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f55c94 - Browse repository at this point
Copy the full SHA 8f55c94View commit details -
Create private
nextTick
utility.In order to ensure "time traveling" (sinon's fake timers, timecop, etc) we need to capture our `setTimeout` early during evaluation.
Configuration menu - View commit details
-
Copy full SHA for 88beb6b - Browse repository at this point
Copy the full SHA 88beb6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 043c4bc - Browse repository at this point
Copy the full SHA 043c4bcView commit details -
Add monkey patch for QUnit until qunit > 2.4.1 is released.
Brings in the changes from qunitjs/qunit@6a7910a.
Configuration menu - View commit details
-
Copy full SHA for cf98536 - Browse repository at this point
Copy the full SHA cf98536View commit details -
Configuration menu - View commit details
-
Copy full SHA for c919c77 - Browse repository at this point
Copy the full SHA c919c77View commit details -
* ensure always async * fire correct events (in order) To ensure correct event order, used the following snippet: ```js let element = document.createElement('input'); ['blur', 'focusout'].forEach(type => { element.addEventListener(type, () => { console.log('event:', type); }); }); document.body.appendChild(element); ```
Configuration menu - View commit details
-
Copy full SHA for 58441b0 - Browse repository at this point
Copy the full SHA 58441b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f10141 - Browse repository at this point
Copy the full SHA 1f10141View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88c88ed - Browse repository at this point
Copy the full SHA 88c88edView commit details -
Add and utilize
nextTickPromise
helper method.Prior to this change the `nextTick` would run and _might_ not be properly waited on by the returned `settle()` promise (though in practice `nextTick` did finish first). This updates to ensure that we only return `settled()` after the actual events have been fired.
Configuration menu - View commit details
-
Copy full SHA for e523951 - Browse repository at this point
Copy the full SHA e523951View commit details -
Configuration menu - View commit details
-
Copy full SHA for b751706 - Browse repository at this point
Copy the full SHA b751706View commit details -
Configuration menu - View commit details
-
Copy full SHA for d21bf56 - Browse repository at this point
Copy the full SHA d21bf56View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbd0353 - Browse repository at this point
Copy the full SHA fbd0353View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d17cc9 - Browse repository at this point
Copy the full SHA 6d17cc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48ab310 - Browse repository at this point
Copy the full SHA 48ab310View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2221b42 - Browse repository at this point
Copy the full SHA 2221b42View commit details -
Initial implementation of
fillIn
.Intial implementation from https://github.com/cibernox/ember-native-dom-helpers, but modified in a few ways: * Ensure validations are ran sync * Ensure events are triggered async * Remove run loop wrapping * Tweak error message and validation.
Configuration menu - View commit details
-
Copy full SHA for 83444ea - Browse repository at this point
Copy the full SHA 83444eaView commit details -
Mark internal helper functions as private.
Also add extra underscores :P
Configuration menu - View commit details
-
Copy full SHA for 5988674 - Browse repository at this point
Copy the full SHA 5988674View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b7da22 - Browse repository at this point
Copy the full SHA 5b7da22View commit details -
* Use `target` to mean `selectorOrElement` * Properly indicate optional params * Show default values
Configuration menu - View commit details
-
Copy full SHA for ca88ee2 - Browse repository at this point
Copy the full SHA ca88ee2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ffe33c - Browse repository at this point
Copy the full SHA 1ffe33cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d91821c - Browse repository at this point
Copy the full SHA d91821cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f34b26 - Browse repository at this point
Copy the full SHA 2f34b26View commit details -
Avoid `setContext(this)` (use `setContext(localVariable)`) to make it much clearer what is going on.
Configuration menu - View commit details
-
Copy full SHA for 61222a5 - Browse repository at this point
Copy the full SHA 61222a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6073e4 - Browse repository at this point
Copy the full SHA b6073e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ead022a - Browse repository at this point
Copy the full SHA ead022aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62e22c7 - Browse repository at this point
Copy the full SHA 62e22c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 612c815 - Browse repository at this point
Copy the full SHA 612c815View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2b3c35 - Browse repository at this point
Copy the full SHA f2b3c35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cc394e - Browse repository at this point
Copy the full SHA 2cc394eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f03eead - Browse repository at this point
Copy the full SHA f03eeadView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c23057 - Browse repository at this point
Copy the full SHA 5c23057View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a8b97d - Browse repository at this point
Copy the full SHA 2a8b97dView commit details -
Configuration menu - View commit details
-
Copy full SHA for caf3e13 - Browse repository at this point
Copy the full SHA caf3e13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b3d7c1 - Browse repository at this point
Copy the full SHA 3b3d7c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 326b968 - Browse repository at this point
Copy the full SHA 326b968View commit details -
Remove tests requiring
click
only wait for subset of settledness.These tests previously used a sync version of click that allowed `settled` to be tested with _only_ waiting for some portions of settledness. When the tests were converted to use the new public version of `click` the test began failing (because `click` doesn't kick off until the next tick of the event loop, so `settled` resolves immediately).
Configuration menu - View commit details
-
Copy full SHA for fdefbc9 - Browse repository at this point
Copy the full SHA fdefbc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95b34ee - Browse repository at this point
Copy the full SHA 95b34eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for adb006b - Browse repository at this point
Copy the full SHA adb006bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ee206a - Browse repository at this point
Copy the full SHA 7ee206aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e41f7f - Browse repository at this point
Copy the full SHA 7e41f7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e6f8668 - Browse repository at this point
Copy the full SHA e6f8668View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0412bbf - Browse repository at this point
Copy the full SHA 0412bbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for d07492b - Browse repository at this point
Copy the full SHA d07492bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1848f83 - Browse repository at this point
Copy the full SHA 1848f83View commit details