Commits on Dec 13, 2017

1. Refactor settled to avoid triggering a new run-loop. …

   The code that was added to ensure that all `promise.then` or
   `promise.catch` callbacks are "flushed" before decrementing the counter
   (which fixed a number of bugs where `settled` would accidentally become
   `true` before the promise callbacks themselves could have a chance to
   run), caused an issue when using the legacy `moduleForComponent` system
   to render a template that itself kicked off an async request.
   
   Prior to the changes made in this commit, when rendering would kick off
   async (e.g. rendering a `{{parent.child}}` style path referencing an
   ember-data async relationship) there would _already_ be an existing
   `Ember.run.backburner.currentInstance` (which was created by the
   `RSVP.Promise.resolve().then(...)` being removed in this commit) which
   ultimately forced us down the path that meant `adapter.asyncStart()` /
   `adapter.asyncEnd()` would not be called ([see
   here](https://github.com/emberjs/ember.js/blob/v2.17.0/packages/ember-testing/lib/ext/rsvp.js#L11)).
   
   This change works around that (admittedly niche) scenario by always
   assuming that a `Promise.resolve()` will execute before the next
   `setTimeout(cb, 0)` (which is true in both Ember.RSVP land and native
   Promise land).

   

   rwjblue committed Dec 13, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for 069e681
   • Browse repository at this point

   Copy the full SHA

   069e681 View commit details

   Browse the repository at this point in the history