Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup browser detection and overrides. #280

Merged
merged 2 commits into from
Dec 18, 2017

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Dec 16, 2017

Mentioned in #277 (review).

It makes no sense, I know. But it definitely is correct.
Only the `blurSteps `are different than the default. This makes that
clearer.
@@ -1,4 +1,4 @@
// `window.ActiveXObject` returns undefined in IE11 (as well as non-IE browsers)
// `window.ActiveXObject` is "falsey" in IE11 (but not `undefined` or `false`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what the ...!?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INDEED!

@rwjblue rwjblue merged commit b0f037b into emberjs:master Dec 18, 2017
@rwjblue rwjblue deleted the cleanup-browser-detect branch December 18, 2017 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants