add waitFor msg #356
Merged
add waitFor msg #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
commented
Apr 5, 2018
| @@ -15,7 +15,7 @@ import { nextTickPromise } from '../-utils'; | |||
| @param {number} [options.count=null] the number of elements that should match the provided selector (null means one or more) | |||
| @returns {Element|Array<Element>} the element (or array of elements) that were being waited upon | |||
| */ | |||
| export default function waitFor(selector, { timeout = 1000, count = null } = {}) { | |||
| export default function waitFor(selector, { timeout = 1000, count = null, timeoutMessage = 'waitFor timed out' } = {}) { | |||
There was a problem hiding this comment.
I can revert the default and keep waitUntil timed out if you would like.
rwjblue
requested changes
Apr 5, 2018
tests/unit/dom/wait-for-test.js
Outdated
| @@ -71,11 +71,11 @@ module('DOM Helper: waitFor', function(hooks) { | |||
|
|
|||
| let start = Date.now(); | |||
| try { | |||
| await waitFor('.something', { timeout: 100 }); | |||
| await waitFor('.something', { timeout: 100, timeoutMessage: '.something timed out' }); | |||
There was a problem hiding this comment.
Lets leave this test alone, and add another that is specifically for modifying the timeout message...
| @@ -15,7 +15,7 @@ import { nextTickPromise } from '../-utils'; | |||
| @param {number} [options.count=null] the number of elements that should match the provided selector (null means one or more) | |||
| @returns {Element|Array<Element>} the element (or array of elements) that were being waited upon | |||
| */ | |||
| export default function waitFor(selector, { timeout = 1000, count = null } = {}) { | |||
| export default function waitFor(selector, { timeout = 1000, count = null, timeoutMessage = 'waitFor timed out' } = {}) { | |||
rwjblue
approved these changes
Apr 5, 2018
|
@snewcomer - 👋 looks like some linting failures here still but if you fix those and rebase against master, CI should be green again... |
rwjblue
approved these changes
Apr 20, 2018
rwjblue
requested changes
Apr 20, 2018
There was a problem hiding this comment.
Sorry @snewcomer, I just noticed that we also need to update the docs for the new option, would you mind adding that?
rwjblue
approved these changes
Apr 20, 2018
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opens up
waitForto have atimeoutMessage.