Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript declaration file. #371

Closed

Conversation

jamescdavis
Copy link

This adds a TypeScript type declarations file based on https://github.com/emberjs/ember-test-helpers/blob/master/API.md

@Turbo87
Copy link
Member

Turbo87 commented May 7, 2018

I'm somewhat hesitant of maintaining this in the repo itself unless we use TypeScript for everything directly 🤔

@jamescdavis would you be willing to help port this project to TS if we decided to do so?

@jamescdavis
Copy link
Author

@Turbo87 I certainly understand that concern. Yes, I would definitely be willing to help port to TS. That would be the ideal.

@JonRossway
Copy link

Is it possible there's a missing interface for WaitUntilOptions?

@Turbo87 Turbo87 mentioned this pull request Nov 1, 2018
@rwjblue rwjblue closed this in #450 Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants