don't click when disabled #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
reviewed
Jun 9, 2018
| @@ -59,7 +59,10 @@ export default function click(target) { | |||
| throw new Error(`Element not found when calling \`click('${target}')\`.`); | |||
| } | |||
|
|
|||
| __click__(element); | |||
| if (!element.hasAttribute('disabled')) { | |||
There was a problem hiding this comment.
I think it should check the property instead of the attribute 🤔
Turbo87
approved these changes
Jun 9, 2018
|
I'm confused. I understand that disabled inputs can't be filled, but can't they be clicked? That's surprising |
|
@cibernox I think you're confusing |
|
I'm not. I only expected disabled inputs to not be fillable or focusable, I didn't know they weren't clickable |
rwjblue
requested changes
Jun 9, 2018
| @@ -59,7 +59,10 @@ export default function click(target) { | |||
| throw new Error(`Element not found when calling \`click('${target}')\`.`); | |||
| } | |||
|
|
|||
| __click__(element); | |||
| if (!element.disabled) { | |||
There was a problem hiding this comment.
I think we need to do something like:
let isDisabledFormControl = isFormControl(element) && element.disabled === true;
if (!isDisabledFormControl) {
__click__(element);
}Specifically, adding disabled to random elements doesn't have an effect (e.g. <div disabled></div> still fires events) as it isn't a global attribute. AFAIK disabled is only a thing for form controls...
rwjblue
approved these changes
Jun 9, 2018
|
Thank you @kellyselden! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #383.
Probably affects other helpers.