-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The isolated container exposes Ember's controllers. #4
Conversation
I'm not really sure how to write tests for |
If we are going down this route, we also need |
I'll add them. I'm not familiar with the use cases that would require those classes. So if you want tests for those, which I'm happy to add, I would need some guidance. |
d9c2dec
to
aec2b03
Compare
I would like tests for the scenarios to prevent regressions and whatnot, but I think maybe just having knowledge that a given thing is registered by default by Ember means we should add it... @dgeb - Thoughts? |
aec2b03
to
efcd601
Compare
@rwjblue I agree. It would be nice to have a hook in Ember itself we could call to extract (or perform) default registrations so that duplicate logic doesn't need to be maintained here. However, just getting the registrations in here is a good first step, so thanks @cyril-sf. Please let me know if you plan to add any more tests to this PR. |
It doesn't feel great to use that directly, but I guess it's better for the user ATM. @dgeb I'll add a few more tests |
Those classes are automatically registered by Ember: * Ember.ObjectController * Ember.ArrayController * Ember.Controller * Ember.Route * Ember.View * Ember.Select [Fixes rwjblue/ember-qunit#73]
efcd601
to
00dc7e8
Compare
I've added tests. I'm not super convinced by the Let me know if you think of something better. |
@cyril-sf the tests verify the presence of those items in the container, so they're fine by me. Thanks again! |
The isolated container exposes Ember's controllers.
Thanks @cyril-sf ! |
Those classes are automatically registered by Ember:
Ember.ObjectController
(controller:object
)Ember.ArrayController
(controller:array
)Ember.Controller
(controller:basic
)Ember.Route
(route:basic
)Ember.View
(view:default
andview:toplevel
)Ember.Select
(view:select
)[Fixes rwjblue/ember-qunit#73]