Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Node.js 4 and below #427

Merged
merged 2 commits into from
Oct 14, 2018
Merged

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 13, 2018

Unblocks several dependency updates. This is a breaking change and requires a major version bump! (or a minor bump in this case as we're still pre-1.0)

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove the custom resolutions and unlock the ember-data version in package.json?

@Turbo87
Copy link
Member Author

Turbo87 commented Oct 13, 2018

unlock the ember-data version in package.json?

what do you mean by that? ember-source and ember-cli are also at v3.1.x currently and updating them to something else seems not directly related to dropping Node 4 support 🤔

@rwjblue
Copy link
Member

rwjblue commented Oct 13, 2018 via email

@Turbo87
Copy link
Member Author

Turbo87 commented Oct 13, 2018

@rwjblue I've removed the resolutions, but ember-data is currently pinned to v3.1.1, which seemed okay to me:

"ember-data": "3.1.1",

@rwjblue
Copy link
Member

rwjblue commented Oct 14, 2018

Ya, seems ok, I’m just saying that the reason I pinned it was due to node 4 issues. I’ll fix it in a follow up.

@rwjblue rwjblue merged commit 3839849 into emberjs:master Oct 14, 2018
@Turbo87 Turbo87 mentioned this pull request Nov 1, 2018
@Turbo87 Turbo87 deleted the drop-node-4 branch November 7, 2018 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants