-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Node.js 4 and below #427
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also remove the custom resolutions and unlock the ember-data version in package.json
?
what do you mean by that? |
I was referring to the resolutions field in package.json (where I had added custom resolution overrides to avoid various Node 4 breaking packages) and the fact that I was forced to pin ember-data to a specific 2.18 release because later patch releases broke node 4 compatibility.
Seems _OK_ if you really don’t want to update them here, but they were only pinned due to Node 4 issues so it seemed reasonable to undo in a Node 4 dropping PR to me...
|
@rwjblue I've removed the resolutions, but ember-test-helpers/package.json Line 51 in 03373db
|
Ya, seems ok, I’m just saying that the reason I pinned it was due to node 4 issues. I’ll fix it in a follow up. |
Unblocks several dependency updates. This is a breaking change and requires a major version bump! (or a minor bump in this case as we're still pre-1.0)