Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use name property instead of NAME env var workaround #448

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 1, 2018

didn't know this existed, but apparently ember-data is using this successfully... :)

@rwjblue
Copy link
Member

rwjblue commented Nov 1, 2018

Hehe. It didn’t exist when we added the env var (early in the beta cycle). It was added just as stages went from beta -> stable.

@Turbo87 Turbo87 merged commit ca7ffbd into emberjs:master Nov 1, 2018
@Turbo87 Turbo87 deleted the names-are-hard branch November 1, 2018 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants