Improve type declarations #463
Conversation
| export const KEYBOARD_EVENT_TYPES = Object.freeze(['keydown', 'keypress', 'keyup']); | ||
| const MOUSE_EVENT_TYPES = [ | ||
|
|
||
| export const KEYBOARD_EVENT_TYPES = tuple('keydown', 'keypress', 'keyup'); |
There was a problem hiding this comment.
Totally possible I'm missing something, but what are you getting out of forcing these constants to be tuples rather than arrays?
There was a problem hiding this comment.
export type KeyboardEventType = typeof KEYBOARD_EVENT_TYPES[number];
in the line below this
iirc using a plain array wasn't possible to make this work 🤔
There was a problem hiding this comment.
Ahh, I see—forcing that to be a tuple also narrows the types of the elements as a side effect. What threw me was the fact that you don't ever actually care about the ordering of the elements, which is the normal scenario where you'd use a tuple.
The actual difference is probably negligible (except maybe unless someone else stumbles across this and is also confused), but you can get the type system to infer the narrowest possible element type without converting to a tuple.
There was a problem hiding this comment.
I would use a mapping type here (following the example set in the built-in dom types) to explicitly not care about ordering.
There was a problem hiding this comment.
Is there something reasonable to map to though? In the DOM typings they're mapping the strings to the event interfaces themselves, but I don't see an equivalent "other half" here.
The `disabled` property on these kinds of elements can only be boolean
…is a `Window` instance
... and make `isFocusable()` a user-defined type guard
|
as discussed with @rwjblue last week I'll merge this for now and we can keep iterating on the types afterwards |
\#### 🚀 Enhancement * [emberjs#498](emberjs/ember-test-helpers#498) Add ability to opt-out of automatic settledness waiting in teardown. ([@rwjblue](https://github.com/rwjblue)) \#### 🐛 Bug Fix * [emberjs#497](emberjs/ember-test-helpers#497) Only customize RSVP's async for Ember older than 1.7. ([@rwjblue](https://github.com/rwjblue)) * [emberjs#481](emberjs/ember-test-helpers#481) Allow ember-cli-htmlbars-inline-precompile 2.x and 1.x ([@mydea](https://github.com/mydea)) \#### 🏠 Internal * [emberjs#491](emberjs/ember-test-helpers#491) TravisCI: Remove deprecated `sudo: false` option ([@Turbo87](https://github.com/Turbo87)) * [emberjs#480](emberjs/ember-test-helpers#480) Extract Prettier configuration to .prettierrc.js file. ([@rwjblue](https://github.com/rwjblue)) * [emberjs#463](emberjs/ember-test-helpers#463) Improve type declarations ([@Turbo87](https://github.com/Turbo87)) \#### Committers: 4 - Francesco Novy ([@mydea](https://github.com/mydea)) - Peter Wagenet ([@wagenet](https://github.com/wagenet)) - Robert Jackson ([@rwjblue](https://github.com/rwjblue)) - Tobias Bieniek ([@Turbo87](https://github.com/Turbo87))
/cc @mike-north @chriskrycho @dfreeman @jamescdavis