Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add *.ts to .npmignore. #464

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Nov 7, 2018

We fully intend to publish official types support, however we need a better plan on how to do things. Some specific issues are:

  • How do we ensure we don't break the types accidentally?
  • Since typescript itself does not maintain compatibility across versions, how do we ensure the .d.ts files that we publish will not become incompatible?
  • Do we need an RFC to add this as new public API?

We fully intend to publish official types support, however we need a
better plan on _how_ to do things. Some specific issues are:

* How do we ensure we don't break the types accidentally?
* Since `typescript` itself does not maintain compatibility across
versions, how do we ensure the `.d.ts` files that we publish will not
become incompatible?
* Do we need an RFC to add this as new public API?

[ci skip]
@rwjblue rwjblue requested a review from Turbo87 November 7, 2018 14:32
@rwjblue rwjblue merged commit ce06f66 into emberjs:master Nov 7, 2018
@rwjblue rwjblue deleted the update-npmignore branch November 7, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants