Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and document specifying options to click #553

Merged
merged 1 commit into from Feb 3, 2019
Merged

Test and document specifying options to click #553

merged 1 commit into from Feb 3, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 1, 2019

Fix #551
I copied verifying the key event receiving the modifier by shamelessly stealing from the checkKey helper here

rwjblue
rwjblue approved these changes Feb 3, 2019
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@rwjblue rwjblue changed the title add test for options proxying, usage doc snippet Test and document specifying options to click Feb 3, 2019
@rwjblue rwjblue merged commit 9e67b79 into emberjs:master Feb 3, 2019
@ghost ghost deleted the fix-551 branch February 4, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwjblue @eflanagan0