Add registerDebugInfoHelper API to allow customization of console output during tests.
#608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scalvert
changed the title
|
@rwjblue any thoughts on this? |
rwjblue
reviewed
Apr 12, 2019
|
Done, and also simplified the interface. The conditional check can now be done inside the |
|
@rwjblue I think this is good to go once CI passes. |
rwjblue
reviewed
Apr 15, 2019
| /** | ||
| * Registers a custom debug info helper to augment the output for test isolation validation. | ||
| * | ||
| * @public |
There was a problem hiding this comment.
Sorry, what's wrong here? I'm confused :)
rwjblue
reviewed
Apr 15, 2019
|
I'm seriously not trolling you (tempting though it is!), but there's a bunch of other modules in here that use the |
rwjblue
approved these changes
Apr 25, 2019
4 tasks
rwjblue
changed the title
registerDebugInfoHelper API to allow customization of console output during tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a WIP of an API allowing applications and addons to add their own custom test debug info. Providing this API can allow for tailored information that can assist in debugging test issues.