Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only require ember-cli-typescript while developing #610

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

davewasmer
Copy link
Contributor

See #604 for context.

Wasn't sure what the _incrementalTsCompiler flag was doing - it's not referenced anywhere else in the codebase, so I just removed the reference, but I can add it back if it needs to be something like:

if (this.isDevelopingAddon() && this.project._incrementalTsCompiler) {

Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, thanks for the fix :)

index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@rwjblue rwjblue merged commit 1eb82f9 into emberjs:master Dec 4, 2019
@rwjblue
Copy link
Member

rwjblue commented Dec 4, 2019

Thank you @Turbo87!

@rwjblue rwjblue added bug and removed internal labels May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants