Fix legacy rendering tests (e.g. moduleForComponent) when used with Ember 3.13+
#677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
emberjs/ember.js#18168 fixes the canary regression, I think I'd prefer to fix it in Ember (with that regression test to help make sure we don't break this in the future). What do you think? |
rwjblue
approved these changes
Aug 30, 2019
rwjblue
changed the title
moduleForComponent) when used with Ember 3.13+
|
Thank you, sorry this took so long to land! |
|
No worries! Thanks for merging. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emberjs/ember.js#18096 (comment)
This fixes the latest
ember-canary.