Default click and doubleClick to be left button clicks.
#685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scalvert
requested changes
Jul 17, 2019
rwjblue
reviewed
Jul 25, 2019
|
Thanks for working on this! |
rwjblue
changed the title
|
FYI - Looks like CI failures are due to changes in canary builds of Ember. I'll try to confirm and we can file a separate issue to track fixing those failures. |
rwjblue
changed the title
click and doubleClick to be left button clicks.
|
Rebased and fixed conflicts, should be ready to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, neither click nor double-click helpers were passing the
buttonandbuttonsmouseEvent options necessary to emit a left click. I recently ran into an issue as a library I'm using was specifically looking for 'left' clicks and it dawned on me that this should likely be the default behavior for these helpers.Question for public / repo owners: It's possible, albeit rather unlikely, that this is a breaking change for some people. I'm open to feedback regarding the best way to handle this change so that it does not negatively impact users of this addon.