ensure we correctly cleanup the context #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stefanpenner
commented
Jul 22, 2015
stefanpenner
commented
- pending confirmation in my setup
| @@ -7,3 +7,7 @@ export function setContext(context) { | |||
| export function getContext() { | |||
| return __test_context__; | |||
| } | |||
|
|
|||
| export function unsetContext() { | |||
There was a problem hiding this comment.
Why do we need another method here? Could you call 'setContext(undefined)'?
There was a problem hiding this comment.
wanted it to be very obvious that It was specifically to unset, not just an overloaded the existing set.
|
@stefanpenner 👍 Thanks for dedicating your Mondays to fixing leaks. |
|
Maybe I should spend Tuesday's learning how to spell:p |
|
@rwjblue i think this is good to go. |
stefanpenner
changed the title
rwjblue
added a commit
that referenced
this pull request
Jul 23, 2015
unsure we correctly cleanup the context
|
Released in:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.