Issue 794 - add deprecation messages to this.render and this.clearRender #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
May 21, 2020
addon-test-support/@ember/test-helpers/setup-rendering-context.ts
Outdated
Show resolved
Hide resolved
rwjblue
approved these changes
May 21, 2020
|
Hmm, looks like this might need a rebase actually. I see a number of commits here that are not part of the changes being added. |
|
hmm i just tried to rebase, but not sure if i did it correctly |
Mikek2252
changed the base branch from
master
to
dependabot/npm_and_yarn/fs-extra-9.0.0
Mikek2252
changed the base branch from
dependabot/npm_and_yarn/fs-extra-9.0.0
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#794
Added deprecation warnings to both functions when added to this.
@rwjblue wasn't sure what number to put the until under so have a place holder at the moment.