Remove dependencies that are actually dev dependencies #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadhietala
changed the title
chadhietala
force-pushed
the
remove-ember-data
branch
from
5e169a9
to
1a0abe8
Compare
|
Moving pretender is good, but we can't move ember-data until ember-cli/ember-try#36 is released. |
|
@rwjblue Anything that is blocking the release? |
|
Not to my knowledge, but I'm not sure what @kategengler's release schedule looks like... |
|
@rwjblue Released 0.0.8. I had no idea anyone was waiting for a release until now. |
|
@kategengler - It's been roughly 9 hours since this PR was made, I think you are pretty on the ball 😸 |
chadhietala
force-pushed
the
remove-ember-data
branch
from
1a0abe8
to
6892351
Compare
|
Need to move https://github.com/switchfly/ember-test-helpers/blob/master/config/ember-try.js#L7 and https://github.com/switchfly/ember-test-helpers/blob/master/config/ember-try.js#L14 into |
chadhietala
force-pushed
the
remove-ember-data
branch
from
6892351
to
90d01b6
Compare
|
All green 🍏 |
rwjblue
added a commit
that referenced
this pull request
Jul 24, 2015
Remove dependencies that are actually dev dependencies
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried upgrading to patch memory leaks, our tooling freaked out because it attempted to pull stuff from outside the fire wall that is not needed for runtime.