Remove usage of ember-cli-version-checker's old .forEmber API
#915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't actually have a dependency on `ember-cli-version-checker` so our version was not stable, and a recent update broke it. I _think_ all we need to do is remove the guarding and whatnot, since more modern versions of the tooling that we rely on already works well.
rwjblue
force-pushed
the
remove-usage-of-forEmber
branch
from
b4c01c6
to
b1afe14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't actually have a dependency on
ember-cli-version-checkerso our version was not stable, and a recent update broke it.I think all we need to do is remove the guarding and whatnot, since more modern versions of the tooling that we rely on already works well.