Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes interop issue between native promises and RSVP promises in test helper hooks #927

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

drewlee
Copy link
Contributor

@drewlee drewlee commented Oct 29, 2020

For reasons I'm not too sure of, the interoperability between the RSVP promise which is utilized by nextTickPromise and the native Promise used at:

causes numerous component test failures throughout our test suites. Using RSVP's Promise.all instead, fixes the test failures.

@drewlee
Copy link
Contributor Author

drewlee commented Oct 29, 2020

@scalvert @rwjblue if you could take a look. Thanks!

@scalvert scalvert merged commit 20a2841 into emberjs:master Oct 29, 2020
@scalvert scalvert added the bug label Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants