[Bug] Types in 5.1 refer to missing dependencies #20479
Comments
ef4
added a commit
to embroider-build/embroider
that referenced
this issue
Jun 27, 2023
ember-source 5.1 is out but it cannot typecheck correctly in an apps yet due to: - emberjs/ember.js#20479 - emberjs/ember-test-helpers#1389
chriskrycho
added a commit
that referenced
this issue
Jun 28, 2023
- Include `@simple-dom/interface` as an explicit dependency so it is present in the graph for consumers who will not be getting it transitively from `@glimmer/*` deps which are pre-built into Ember. Fixes #20479.
chriskrycho
added a commit
that referenced
this issue
Jun 28, 2023
Add `@simple-dom/interface` and `@glimmer/syntax` to `dependencies` so they are present in the graph for consumers who will not be getting them transitively from the `@glimmer/*` deps which are pre-built into Ember. (Medium-term, it would be preferable for our type emit to roll up these kinds of dependencies the same way Ember's build does *or* for Ember's build to stop rolling them up; whichever we choose, the goal will be for them to *match*.) Fixes #20479.
chriskrycho
added a commit
that referenced
this issue
Jun 29, 2023
Add `@simple-dom/interface` and `@glimmer/syntax` to `dependencies` so they are present in the graph for consumers who will not be getting them transitively from the `@glimmer/*` deps which are pre-built into Ember. (Medium-term, it would be preferable for our type emit to roll up these kinds of dependencies the same way Ember's build does *or* for Ember's build to stop rolling them up; whichever we choose, the goal will be for them to *match*.) Fixes #20479. (cherry picked from commit cf03749)
chriskrycho
added a commit
that referenced
this issue
Jun 29, 2023
Add `@simple-dom/interface` and `@glimmer/syntax` to `dependencies` so they are present in the graph for consumers who will not be getting them transitively from the `@glimmer/*` deps which are pre-built into Ember. (Medium-term, it would be preferable for our type emit to roll up these kinds of dependencies the same way Ember's build does *or* for Ember's build to stop rolling them up; whichever we choose, the goal will be for them to *match*.) Fixes #20479. (cherry picked from commit cf03749)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐞 Describe the Bug
The new stable types in ember-source 5.1 import from
@simple-dom/interfaceand@glimmer/syntax, neither of which is a declared dependency that's guaranteed to be present in an app.Both of them are interior dependencies of ember's devDependencies.
🔬 Minimal Reproduction
You can see this failing in embroider CI here:
https://github.com/embroider-build/embroider/actions/runs/5391837867/jobs/9789371760
The text was updated successfully, but these errors were encountered: