[CLEANUP beta] Remove deprecated Registry and Container behavior #11853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Registry no longer instantiates a container and forwards lookup/lookupFactory to it. * Removed checks for `ember-application-instance-initializers` and `ember-application-initializer-context` since they have been enabled by default for ~4 months now.
* Containers no longer create a registry if one is not supplied to the constructor. * Containers no longer expose their associated registry's interfaces.
dgeb
changed the title
dgeb
changed the title
|
@rwjblue so, as we just discussed, that code in ember-test-helpers existed solely to quiet the deprecations (which are now removed with this PR). We can now test for its need in ember-test-helpers with a |
|
PR submitted upstream: emberjs/ember-test-helpers#85 |
rwjblue
added a commit
that referenced
this pull request
Jul 21, 2015
[CLEANUP beta] Remove deprecated Registry and Container behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebases @cibernox's PR #11756, which performs the following:
lookup/lookupFactoryto it.ember-application-instance-initializersandember-application-initializer-contextsince they have been enabled by default for ~4 months now.Also performs the following associated cleanup of deprecated container behavior: