-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link component hook #230
Link component hook #230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main concerns are around:
- adding more things to
LinkComponent
(you already have this in the drawbacks section) - naming of
eventAction
, is there another name that might work better? - if we are going to allow folks to override we should allow them to actually use the default (e.g. adding custom tracking functional would still want to call the current _invoke)
0000-template.md
Outdated
@@ -1,52 +0,0 @@ | |||
- Start Date: (fill me in with today's date, YYYY-MM-DD) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't be deleted, can you bring it back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
embarrassing :o
@rwjblue unless I'm missing something, the 3rd point is already covered. The new |
Mostly copied/stolen from emberjs's packages/ember-testing/lib/events.js but with some tweaks to make it work without jQuery (I think those changes were made upstream in Ember as well). The long term goal here is to remove this file and have ember-test-helpers _include_ the helpers from ember-native-dom-helpers, but that will require an RFC once the changes proposed in emberjs/rfcs#230 are implemented.
This was added in an early attempt to simplify / separate things for the "grand testing unification" RFC, but ultimately was never rolled out to folks. At this point, it has become clear that this class based system for managing test setup is not the way forward (see emberjs/rfcs#230 for details) and this module (that is unused) has just become "dead weight" maintenance wise.
Moves all of the future deprecated code into a `legacy-0-6-x` subfolder (while preserving import paths) in order to ease implementation of emberjs/rfcs#230.
Moves all of the future deprecated code into a `legacy-0-6-x` subfolder (while preserving import paths) in order to ease implementation of emberjs/rfcs#230.
Moving into FCP to close for this, I think the right path forward for folks here is to not use |
rendered