This repository has been archived by the owner on Mar 22, 2019. It is now read-only.
Adds Native Class Constructor Update write-up to blog #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayjayjpg
reviewed
Jun 20, 2018
| ## [SECTION TITLE](section url) | ||
| ## [Native Class Constructor Update 🛠](https://github.com/emberjs/rfcs/pull/337) | ||
|
|
||
| There is currently an open RFC proposing to change the behavior of EmberObject's constructor. |
There was a problem hiding this comment.
We aimed to put anything that describes Ember objects, methods or similar things into code quotes (``) in the past - I think it would make sense to put any mentions of EmberObject into ``, too so, it'd become EmberObject.
What do you think?
| This would assign the properties _after_ all of the class fields for any subclasses have been assigned. | ||
|
|
||
| One thing worth mentioning is that EmberObject will likely be deprecated in the near future and that ideally for non-Ember classes (things that aren't Components, Services, etc.) users should drop EmberObject altogether and use native classes only. | ||
|
|
There was a problem hiding this comment.
I think it'd be cool to add a final call-to action as well, reminding people that they can comment on the RFC to help finalizing it - what do you think?
jayjayjpg
approved these changes
Jun 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Native Class Constructor Update write-up to blog