Improve Response.dragged, drag_started and clicked
#3888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmesingFlank
added a commit
to AmesingFlank/LightSalon
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a widgets sense both clicks and drags, we don't know wether or not a mouse press on it will be a short click or a long drag.
With this PR,
response.draggedandresponse.drag_startedisn't true until we know it is a drag and not a click.If the widget ONLY senses drags, then we know as soon as someone presses on it that it is a drag.
If it is sensitive to both clicks and drags, we don't know until the mouse moves a bit, or stays pressed down long enough.
This PR also ensures that
response.clickedand is only true for widgets that senses clicks.