Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a UiBuilder for building Uis #4969

Merged
merged 15 commits into from
Aug 26, 2024
Merged

Create a UiBuilder for building Uis #4969

merged 15 commits into from
Aug 26, 2024

Conversation

emilk
Copy link
Owner

@emilk emilk commented Aug 15, 2024 •
edited
Loading

The goals is to create fewer, more powerful entry points.

Added

  • egui::UiBuilder
  • Ui::allocate_new_ui
  • Ui::new_child

Breaking changes

  • Ui::new now takes a UiBuilder
  • Deprecated
    • ui.add_visible_ui
    • ui.allocate_ui_at_rect
    • ui.child_ui
    • ui.child_ui_with_id_source
    • ui.push_stack_info

@emilk emilk added this to the Next Major Release milestone Aug 15, 2024
@emilk emilk added the egui label Aug 16, 2024
@emilk emilk marked this pull request as ready for review August 16, 2024 09:49
bircni
bircni approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@bircni bircni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

@emilk emilk merged commit 5a196f6 into master Aug 26, 2024
35 checks passed
@emilk emilk deleted the emilk/ui_builder branch August 26, 2024 06:51
@emilk emilk added the feature New feature or request label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bircni bircni bircni approved these changes

Assignees
No one assigned
Labels
egui feature New feature or request
Projects
None yet
Milestone
Next Major Release
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @bircni