Prepare for Envoy 1.13 upgrade; migrate from now-disabled deprecated fields #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeShu
changed the title
LukeShu
commented
Feb 19, 2020
| "operation_name": "egress" | ||
| } | ||
| self.base_http_config["tracing"] = {} | ||
| self.traffic_direction = "OUTBOUND" |
There was a problem hiding this comment.
This seems wrong-ish to me, but I think it's what preserves existing behavior.
There was a problem hiding this comment.
I think you're correct. @alexgervais might have some thoughts as to whether we should support configuring this.
There was a problem hiding this comment.
LGTM
At some point, "operation_name": "egress" was required for tracing to work on upstream calls. Having a quick look at the docs, and it would seem traffic_direction could be omitted entirely. Anyways, I'd be happy to test tracing manually before shipping.
This is driven by "which of these cause test failures". It is NOT an audit of the codebase cross-referenced with <https://www.envoyproxy.io/docs/envoy/latest/intro/deprecated>. It would be a good idea to do that audit at some point.
LukeShu
force-pushed
the
lukeshu/remove-deprecated
branch
from
310bb7b
to
b0b7bd8
Compare
LukeShu
changed the title
kflynn
approved these changes
Feb 20, 2020
| "operation_name": "egress" | ||
| } | ||
| self.base_http_config["tracing"] = {} | ||
| self.traffic_direction = "OUTBOUND" |
There was a problem hiding this comment.
I think you're correct. @alexgervais might have some thoughts as to whether we should support configuring this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is everything (so far?) that is a part of upgrading to Envoy 1.13, short of doing the actual upgrade and things that depend on the actual upgrade. The biggest part of that is dealing with Envoy disallowing many previously deprecated fields (datawire/apro#713).
It probably makes sense to review this commit-by-commit.
Related Issues
PR #2318
Issue datawire/apro#713
Issue datawire/apro#998