Extract isPrintable to helper function

emotion-js · Dec 5, 2019 · c2e66af · c2e66af
1 parent e16b653
commit c2e66af
Showing 1 changed file with 17 additions and 12 deletions.
diff --git a/packages/jest-emotion/src/index.js b/packages/jest-emotion/src/index.js
@@ -113,9 +113,11 @@ function isShallowEnzymeElement(element: any, classNames: string[]) {
   return !hasIntersection(classNames, childClassNames)
 }
 
-const creatConvertEmotionElements = (keys: string[], printer: *) => (
-  node: any
-) => {
+const creatConvertEmotionElements = (
+  keys: string[],
+  printer: *,
+  isPrintable: (node: *) => boolean
+) => (node: any) => {
   if (isPrimitive(node)) {
     return node
   }
@@ -156,7 +158,7 @@ const creatConvertEmotionElements = (keys: string[], printer: *) => (
       [TRANSFORMED]: true
     }
   }
-  if (isReactElement(node) || isDOMElement(node)) {
+  if (isPrintable(node)) {
     return {
       ...node,
       [TRANSFORMED]: true
@@ -198,11 +200,17 @@ export function createSerializer({
   DOMElements = true
 }: Options = {}) {
   const cache = new WeakSet()
+  const isPrintable = (node: *) =>
+    isReactElement(node) || (DOMElements && isDOMElement(node))
   function print(val: *, printer: Function) {
-    const seen = cache.has(val)
+    const isNestedPrint = cache.has(val)
     const elements = getStyleElements()
     const keys = getKeys(elements)
-    const convertEmotionElements = creatConvertEmotionElements(keys, printer)
+    const convertEmotionElements = creatConvertEmotionElements(
+      keys,
+      printer,
+      isPrintable
+    )
     const converted = deepTransform(val, convertEmotionElements)
     const nodes = getNodes(converted)
     nodes.forEach(cache.add, cache)
@@ -211,7 +219,7 @@ export function createSerializer({
     clean(converted, classNames)
     const printedVal = printer(converted)
     nodes.forEach(cache.delete, cache)
-    return seen
+    return isNestedPrint
       ? printedVal
       : replaceClassNames(
           classNames,
@@ -223,12 +231,9 @@ export function createSerializer({
   }
 
   function test(val: *) {
-    return (
-      val &&
-      (!val[TRANSFORMED] &&
-        (isReactElement(val) || (DOMElements && isDOMElement(val))))
-    )
+    return val && !val[TRANSFORMED] && isPrintable(val)
   }
+
   return { test, print }
 }