Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v11] @emotion/native types are based on old react-native types. #1749

Closed
Zn4rK opened this issue Feb 5, 2020 · 3 comments
Closed

[v11] @emotion/native types are based on old react-native types. #1749

Zn4rK opened this issue Feb 5, 2020 · 3 comments

Comments

@Zn4rK
Copy link
Contributor

Zn4rK commented Feb 5, 2020

Current behavior:

Both ActivityIndicatorIOS and WebView are included in the Pick from @types/react-native@0.57.0.
Both of which seems to be gone in the latest version of @types/react-native@^0.61.10

I'm getting:
Type '"ActivityIndicatorIOS"' is not assignable to type '"ActivityIndicator" | "Button" | "DatePickerIOS" | "DrawerLayoutAndroid" | "FlatList" | "Image" | "ImageBackground" | "KeyboardAvoidingView" | "ListView" | "Modal" | "NavigatorIOS" | ... 147 more ... | "ViewPropTypes"'.

To reproduce:

Compile TypeScript-project that uses the types and a newer version of react-native.

Expected behavior:

I would expect to be able to use the latest version of react-native (and @types/react-native).

Environment information:

  • react version: n/a
  • emotion version: @emotion/native@11.0.0-next.11
@Andarist
Copy link
Member

Andarist commented Feb 6, 2020

Feel free to open a PR to fix this.

cc @patsissons , i guess there is really no way to support a wide range of RN versions, right? So we should just stick to supporting latest

@Zn4rK Zn4rK mentioned this issue Feb 6, 2020
4 tasks
@patsissons
Copy link
Contributor

I think I just aligned with whatever was being used in the native package at the time.

@Andarist
Copy link
Member

closed by #1750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants