[v11] fixed native typings #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 05868ef We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 05868ef:
|
Andarist
reviewed
Feb 27, 2020
|
Thanks for the PR! Sorry that it took so long to handle this. |
louisgv
pushed a commit
to louisgv/emotion
that referenced
this pull request
Sep 6, 2020
…n of React Native (0.61.5) (emotion-js#1750) * Fixed native typings * Updated monorepo package.json * Update changeset Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fixes #1749
Why:
Typings for
@emotion/nativewasn't aligned with the latestreact-nativetypes.How:
I upgraded the react-native versions in
packages/native/package.jsonand removed the missing types from the union.I also removed the two entries in the components-array thats sets getters on the styled-object.
So the types are aligned with the expected functionality.
Checklist: