Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @emotion/* dependencies to babel-plugin-emotion READMEs #1254

Closed
wants to merge 1 commit into from
Closed

Add @emotion/* dependencies to babel-plugin-emotion READMEs #1254

wants to merge 1 commit into from

Commits on Mar 1, 2019

  1. Add @emotion/* dependencies to babel-plugin-emotion READMEs 

    babel-plugin-emotion includes macros which may generate application code
that imports these packages, e.g.

    import _styled from "@emotion/styled-base";

Normally, this is not a problem when using popular package managers like
npm / yarn because '@emotion/styled-base' is a transitive
dependency of '@emotion/styled', which is hoisted to the root
node_modules folder, enabling it to be found by webpack / node:

    node_modules/
      @emotion/styled/
        ...
      @emotion/styled-base/
        ...

But when using strict package managers such as pnpm (or yarn pnp),
@emotion/styled-base cannot be resolved because it can only be resolved
by code inside the @emotion/styled package:

    node_modules/
      @emotion/styled/
        ...
        node_modules/
          @emotion/styled-base/
          ...

Adding these to the respective READMEs of both babel packages should
help users avoid this issue.
    @elliottsj
    elliottsj committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    bebd5ac View commit details
    Browse the repository at this point in the history