Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jest emotion/improvements #1604

Merged
merged 4 commits into from
Nov 4, 2019
Merged

Jest emotion/improvements #1604

merged 4 commits into from
Nov 4, 2019

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Nov 4, 2019

Match rules in declarations with component used as a selector and take specificity into account when matching styles

fixes #1214

@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2019

🦋 Changeset is good to go

Latest commit: 86e5d8b

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@FezVrasta
Copy link
Member

Thanks!

@@ -1282,6 +1282,16 @@
exec-sh "^0.3.2"
minimist "^1.2.0"

"@emotion/babel-preset-css-prop@^10.0.5":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure why our babel plugins were added to the lock 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It usually happens if some dependency is referencing a version different from latest, or when yarn shits its pants (it happens often)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I've found why this has happened right now with a help of yarn why - those are dependencies of gatsby-plugin-emotion, so it makes sense that they have been added

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #1604 into next will decrease coverage by 0.08%.
The diff coverage is 95.65%.

Impacted Files Coverage Δ
packages/jest-emotion/src/matchers.js 96.87% <100%> (+0.72%) ⬆️
packages/jest-emotion/src/utils.js 96.9% <92.3%> (-1.95%) ⬇️

Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@emmatown emmatown merged commit e67a5be into next Nov 4, 2019
@emmatown emmatown deleted the jest-emotion/improvements branch November 4, 2019 20:42
louisgv pushed a commit to louisgv/emotion that referenced this pull request Sep 6, 2020
* Match rules in declarations with component used as a selector

* Take specificity into account when matching styles

* add changesets

* fix flow errors
@github-actions github-actions bot mentioned this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants