Added basic support for accepting custom shouldForwardProp option in React Native related packages.
#1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: acae230 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
commented
Nov 18, 2019
| let mergedProps = pickAssign(testAlwaysTrue, {}, props, { | ||
| theme: props.theme || React.useContext(ThemeContext) | ||
| }) | ||
| let mergedProps = props |
There was a problem hiding this comment.
those changes align the implementation to what we have in @emotion/styled
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit acae230:
|
…n React Native related packages.
Andarist
force-pushed
the
native/should-forward-prop
branch
from
2bc12ad
to
acae230
Compare
Codecov Report
|
|
I'm going to just merge this in as native packages are not our main focus. I'm open to review even after merging - changes are rather trivial though, so 🤷♂ |
louisgv
pushed a commit
to louisgv/emotion
that referenced
this pull request
Sep 6, 2020
…n React Native related packages. (emotion-js#1642)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #900
There is an open PR for adding TS types for
@emotion/native- #1634 - and I'd like to keep those types in sync with what we have for@emotion/styledand to make it easier I had to implement basic support for this here.