Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling of the css prop in syntax-preference rule #1659

Merged
merged 2 commits into from
Dec 8, 2019

Conversation

Andarist
Copy link
Member

closes #1253

Our ESLint could certainly get some more love, but for now, this PR focuses on a single thing - validating which kind of syntax gets used in combination with css prop.

@changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2019

🦋 Changeset is good to go

Latest commit: d1f9249

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 28, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d1f9249:

Sandbox Source
Emotion Configuration

@Andarist Andarist force-pushed the eslint-prefer-syntax-css-prop branch from 767ccfc to d60d44b Compare November 28, 2019 23:37
@Andarist Andarist force-pushed the eslint-prefer-syntax-css-prop branch from d60d44b to 1c66428 Compare November 29, 2019 21:40
@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #1659 into next will decrease coverage by 0.33%.
The diff coverage is 86.2%.

Impacted Files Coverage Δ
packages/styled/src/base.js 100% <ø> (ø) ⬆️
packages/sheet/src/index.js 100% <ø> (ø) ⬆️
packages/core/src/class-names.js 100% <ø> (ø) ⬆️
packages/create-emotion-server/src/inline.js 100% <ø> (ø) ⬆️
packages/core/src/jsx.js 100% <ø> (ø) ⬆️
...lint-plugin-emotion/src/rules/syntax-preference.js 87.09% <86.2%> (-12.91%) ⬇️

@Andarist
Copy link
Member Author

Andarist commented Dec 7, 2019

@mitchellhamilton friendly 🏓

@Andarist Andarist merged commit 8b59959 into next Dec 8, 2019
@Andarist Andarist deleted the eslint-prefer-syntax-css-prop branch December 8, 2019 10:02
louisgv pushed a commit to louisgv/emotion that referenced this pull request Sep 6, 2020
* Add handling of the css prop in syntax-preference rule

* add changeset
@github-actions github-actions bot mentioned this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants