Rename packages #1675
Merged
Rename packages #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: efa8fae We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
reviewed
Dec 8, 2019
Andarist
reviewed
Dec 8, 2019
|
|
||
| If you have used `@emotion/css` directly (it was always reexported from `@emotion/core`) or you have been using its macro then you should update your code like this: | ||
| If you have used `@emotion/css` directly (it was always reexported from `@emotion/react`) or you have been using its macro then you should update your code like this: |
There was a problem hiding this comment.
We should review all changesets & changelogs carefully after merging this in. Some changesets should still refer to old names, like for example in here - it should still stay as "(it was always reexported from @emotion/core".
And probably best to keep copies of existing changelogs in old and new packages?
There was a problem hiding this comment.
bump - we should mentioned here that it was always reexported from @emotion/core, optionally we can mention that it has been renamed now to @emotion/react
Andarist
reviewed
Dec 8, 2019
Andarist
reviewed
Dec 8, 2019
Andarist
reviewed
Dec 8, 2019
Co-Authored-By: Mateusz Burzyński <mateuszburzynski@gmail.com>
Co-Authored-By: Mateusz Burzyński <mateuszburzynski@gmail.com>
Co-Authored-By: Mateusz Burzyński <mateuszburzynski@gmail.com>
It is true for all packages that are linked(as in the Changesets option). Here is the result of
Done. |
Andarist
reviewed
Dec 24, 2019
Codecov Report
|
|
Besides few unresolved comments - looks good 👍 Note that I've pushed out a syntax error fix to this branch. |
Co-Authored-By: Mateusz Burzyński <mateuszburzynski@gmail.com>
Andarist
reviewed
Jan 3, 2020
Andarist
reviewed
Jan 3, 2020
| - [Global Styles — `injectGlobal`](#global-styles) | ||
| - [Animation Keyframes — `keyframes`](#animation-keyframes) | ||
| - [Composing Class Names — `cx`](#cx) | ||
| - [Server Side Rendering](https://emotion.sh/docs/ssr#api) |
There was a problem hiding this comment.
those 2 last things should point to a local repo paths, shouldnt they? at the moment they point to external site
There was a problem hiding this comment.
The site removes the https://emotion.sh so it points to the site on npm/GitHub and it points to local url on the site so it works on deploy previews, e.g. https://deploy-preview-1675--emotion.netlify.com/docs/@emotion/css
There was a problem hiding this comment.
It won't work directly when using GitHub or exploring a checked out repository though.
There was a problem hiding this comment.
Yeah, that's true but the alternatives are:
- absolute path relative to the root or relative path from the README - works on GH and I think the site but is broken on npm
- GitHub url to the root - links to the file on master always so it's not on the right branch
So I think this solution is the best of the three
louisgv
pushed a commit
to louisgv/emotion
that referenced
this pull request
Sep 6, 2020
* WIP codemod for renaming * Lockfile changes * emotion -> @emotion/css * core -> react * Server stuff * Move removed packages to another directory * More things * More things * Some more things * Rename ESLint plugin * Change name in @emotion/eslint-plugin CHANGELOG.md * Jest package and Babel plugin renmaes * Things * Update eslint plugin migration error message * Formatting things * Fix some things * Upgrade babel-eslint * Add @emotion/pkg-renaming rule to ESLint config and run it * Update existing changesets * Add some changesets * Update removed-packages/create-emotion/src/index.js Co-Authored-By: Mateusz Burzyński <mateuszburzynski@gmail.com> * Update removed-packages/emotion/macro.js Co-Authored-By: Mateusz Burzyński <mateuszburzynski@gmail.com> * Update removed-packages/eslint-plugin-emotion/src/index.js Co-Authored-By: Mateusz Burzyński <mateuszburzynski@gmail.com> * Update CodeSandbox CI config * Fix some things * Fix more things * Fix some stuff * Fix some more things * More fixes * Some things * Various updates for babel plugin * Fix more things * Fix another thing * Things * More stuff * Bad linting rules. * More things * More changes * Fix all the babel plugin stuff * Test the Babel plugin in dist tests because it's built now * Fix docs site building maybe * Update some snapshots * Fix some more things * Hopefully actually fix it this time * Replace @emotion/core with @emotion/react in a bunch of places * Fix TS types for @emotion/server/create-instance * Update snapshots * Disable a TSLint rule * More changesets * Docs and things * Fix more things * Fix a thing * Add a test:typescript script * Use glob in CodeSandbox CI config * Fix a thing * Fix TS things * ESLint plugin things * Fix some things * Fix @emotion/server pkg.json syntax error * Update docs/package-summary.mdx Co-Authored-By: Mateusz Burzyński <mateuszburzynski@gmail.com> * Fix some things * Add docs for creating instances of @emotion/css * Fix some little things * Comment out a test * Fix some little things * ts@next.......... Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1635 for context