Fixed some composition issues with styles not containing a final semi #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: d16c2a6 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
commented
Jan 22, 2020
| @@ -264,7 +264,12 @@ function createStringFromObject( | |||
|
|
|||
| if (Array.isArray(obj)) { | |||
| for (let i = 0; i < obj.length; i++) { | |||
| string += handleInterpolation(mergedProps, registered, obj[i], false) | |||
| string += `${handleInterpolation( | |||
There was a problem hiding this comment.
@mitchellhamilton any ideas when this could break stuff? I cant find any, so I think this is safe to do, but would be great to give this a little bit more extra thought.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d16c2a6:
|
Codecov Report
|
|
@mitchellhamilton would you be able to take a look at this? |
emmatown
approved these changes
Feb 29, 2020
Andarist
force-pushed
the
fix/array-css-prop-no-final-semi
branch
from
739178a
to
d16c2a6
Compare
louisgv
pushed a commit
to louisgv/emotion
that referenced
this pull request
Sep 6, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1730