Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change which interface gets extended with css prop support #1762

Merged
merged 2 commits into from
Jul 5, 2020

Conversation

Andarist
Copy link
Member

At the moment this is just a placeholder PR/remainder fo myself - Jessica has mentioned here that we should be able to extend Attributes rather than DOMAttributes. Need to dig deeper to see what's the difference and what kind of an issue does it solve.

@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2020

🦋 Changeset is good to go

Latest commit: 8587053

We got this.

This PR includes changesets to release 2 packages
Name Type
@emotion/react Patch
@emotion/jest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 15, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8587053:

Sandbox Source
Emotion Configuration

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

❗ No coverage uploaded for pull request base (next@d484252). Click here to learn what that means.
The diff coverage is n/a.

Impacted Files Coverage Δ
...ckages/babel-plugin/src/utils/transformer-macro.js 100.00% <0.00%> (ø)
packages/utils/src/index.js 100.00% <0.00%> (ø)
packages/serialize/src/index.js 100.00% <0.00%> (ø)
...ges/server/src/create-instance/extract-critical.js 100.00% <0.00%> (ø)
packages/primitives-core/src/css.js 100.00% <0.00%> (ø)
packages/react/src/utils.js 100.00% <0.00%> (ø)
packages/cache/src/index.js 98.00% <0.00%> (ø)
packages/babel-plugin/src/utils/label.js 97.82% <0.00%> (ø)
packages/react/src/jsx.js 100.00% <0.00%> (ø)
packages/server/src/create-instance/stream.js 100.00% <0.00%> (ø)
... and 74 more

@Andarist Andarist merged commit c7ae475 into next Jul 5, 2020
@Andarist Andarist deleted the Andarist-patch-2 branch July 5, 2020 08:28
@github-actions github-actions bot mentioned this pull request Jul 5, 2020
louisgv pushed a commit to louisgv/emotion that referenced this pull request Sep 6, 2020
…s#1762)

* Change which interface gets extended with css prop support

* Add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant