Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pressable native component #1958

Merged
merged 4 commits into from
Aug 9, 2020
Merged

Add pressable native component #1958

merged 4 commits into from
Aug 9, 2020

Conversation

sanpoChew
Copy link
Contributor

@sanpoChew sanpoChew commented Aug 3, 2020

What: Add support for the new Pressable component introducted in React Native 0.63 https://reactnative.dev/blog/2020/07/06/version-0.63#pressable

Why: Without these changes users are unable to use styled.Pressable to create Pressable components.

How: Added Pressable to the components array in the code and added it to the ReactNativeComponentNames union type.

Checklist:

  • Documentation
  • Tests
  • Code complete
  • Changeset

Not sure if I should run yarn changeset seeing as this would go into next?

@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2020

💥 No Changeset

Latest commit: e5cbd14

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e5cbd14:

Sandbox Source
Emotion Configuration

@sanpoChew
Copy link
Contributor Author

guess this will require a bump of the @types/react-native dependency?

@Andarist
Copy link
Member

Andarist commented Aug 3, 2020

guess this will require a bump of the @types/react-native dependency?

I have done this recently on another branch - so don't worry about it.

Not sure if I should run yarn changeset seeing as this would go into next?

Yes, as we are publishing prereleases from this branch quite often. I can do that later myself though.

@codecov
Copy link

codecov bot commented Aug 9, 2020

Codecov Report

❗ No coverage uploaded for pull request base (next@620f732). Click here to learn what that means.
The diff coverage is n/a.

Impacted Files Coverage Δ
packages/native/src/index.js 100.00% <ø> (ø)
...kages/babel-plugin/src/utils/get-styled-options.js 100.00% <0.00%> (ø)
packages/react/src/keyframes.js 100.00% <0.00%> (ø)
.../babel-plugin/src/utils/transpiled-output-utils.js 82.14% <0.00%> (ø)
packages/server/src/create-instance/stream.js 100.00% <0.00%> (ø)
packages/primitives/src/styled.js 100.00% <0.00%> (ø)
packages/react/macro.js 100.00% <0.00%> (ø)
packages/primitives-core/src/styled.js 100.00% <0.00%> (ø)
packages/server/src/index.js 100.00% <0.00%> (ø)
... and 75 more

@Andarist Andarist merged commit 62fc844 into emotion-js:next Aug 9, 2020
louisgv pushed a commit to louisgv/emotion that referenced this pull request Sep 6, 2020
…on-js#1958)

* add Pressable component to native types

* add new Pressable component to @emotion/native

* Remove ReactNativeComponentNames and simplify typings in the result

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants