Fixed an issue with multiple Emotion caches moving SSRed styles to head at their initialization times #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7719cf3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7719cf3:
|
Andarist
force-pushed
the
fix/multiple-instances-moving-ssr-styles
branch
from
2fe8645
to
a453511
Compare
…ad at their initialization times
Andarist
force-pushed
the
fix/multiple-instances-moving-ssr-styles
branch
from
a453511
to
7719cf3
Compare
emmatown
approved these changes
Oct 3, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1945
If this gets accepted then I'll add changeset and some basic tests. Personally, I'm not super fond of this - I would much rather like to remove this initialization side-effect altogether, but 🤷♂️
This ensures that no styles are moved twice by adding a marker data attribute to: