Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export JSX namespace from automatic runtime entries #2078

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Export JSX namespace from automatic runtime entries #2078

merged 1 commit into from
Nov 9, 2020

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Nov 9, 2020

No description provided.

@Andarist Andarist added the WIP label Nov 9, 2020
@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2020 •
edited
Loading

⚠️ No Changeset found

Latest commit: d06127d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 9, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d06127d:

Sandbox Source
Emotion Configuration

@Andarist Andarist removed the WIP label Nov 9, 2020
@Andarist Andarist marked this pull request as ready for review November 9, 2020 22:10
emmatown
emmatown reviewed Nov 9, 2020
View reviewed changes
packages/react/types/index.d.ts Outdated
}
}
export type Element = EmotionJSX.Element
export type ElementClass = EmotionJSX.ElementClass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should probably be interfaces no?

@Andarist Andarist merged commit 74ec012 into next Nov 9, 2020
@Andarist Andarist deleted the new-runtimes/localized-jsx branch November 9, 2020 23:01
@eps1lon eps1lon mentioned this pull request Nov 20, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatown emmatown emmatown left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andarist @emmatown